-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: debug canary tests #494
Conversation
e47c2e8
to
6a471ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handful of questions/comments.
Nice find on the topic publish test!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Description:
**Test: [topics-service] "Publishes and receives detailed subscription items":**
The test is failing because it's comparing the first received value (aaa) against the second expected value ([1, 2, 3]), which is causing the mismatch. This mismatch is likely because we have extra non-published items, such as a heartbeat, being included in the receivedItems array. The key issue is that we are not filtering out non-TopicItem events (e.g., TopicHeartbeat, TopicDiscontinuity) before doing the comparison with expectedValues.
Hence, this commit compares only the received TopicItem values to the expectedValues.
**Test: [cache-service][scalar-tests] "accurately reports the remaining TTL for a key":**
My hunch is that it can be either of the 3 issues:
I also found that gingko has an inbuilt
BeNumerically
matcher, which is designed specifically to compare numerical values. So, instead of manual boolean checker, using inbuilt matcher to compare original ttl with remaining ttl.