Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unravel Energy Calibration #47

Open
steinnymir opened this issue Dec 10, 2020 · 0 comments
Open

Unravel Energy Calibration #47

steinnymir opened this issue Dec 10, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@steinnymir
Copy link
Member

The processor.energyCalibration method is now growing quickly with many different corrections applied together. These should be separated in different methods, so that they can be tested independently.

Might be a good idea to make functions which do not live inside the processor class, but in the processor.utilities.calibration. These should be functions which all follow the same structure, so that debugging them would be easier.

Such a re-structuring would be good to define for all calibration methods, no matter how simple they might be (see pumpProbeTime calibration)

@steinnymir steinnymir added enhancement New feature or request help wanted Extra attention is needed labels Dec 10, 2020
@steinnymir steinnymir removed the help wanted Extra attention is needed label Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants