Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix: Fixed type error #58

Merged
merged 8 commits into from
Jan 24, 2023
Merged

🐛 fix: Fixed type error #58

merged 8 commits into from
Jan 24, 2023

Conversation

bryanjtc
Copy link
Contributor

Fixes: #57

@bryanjtc
Copy link
Contributor Author

@momocow Important to merge this!

@momocow
Copy link
Owner

momocow commented Jan 19, 2023

The revision looks good to me.

However, I wonder which emoji you are using when facing this bug and why it is not matched by any emoji from the gitmojis package

@momocow
Copy link
Owner

momocow commented Jan 19, 2023

@bryanjtc Please provide the emoji you used when facing this bug and the version of gitmojis you were using, to help me determine if this is a bug of emoji matching like #55 (also see carloscuesta/gitmoji#753).

Anyway, thank you for your fact reaction to this! :)

@bryanjtc
Copy link
Contributor Author

bryanjtc commented Jan 19, 2023 •
edited
Loading

I was using the Hammer emoji like this: :hammer: and gitmojis 3.13.2

@bryanjtc
Copy link
Contributor Author

The Hammer emoji semver value is null. That's why I added the optional chaining in the pr.

@momocow
Copy link
Owner

momocow commented Jan 19, 2023 •
edited
Loading

null value of semver actually won't lead to TypeError: Cannot read properties of undefined (reading 'semver') because the error is arguing the object where semver key resides in to be undefined, not the value itself of the key. 🤔

@momocow
Copy link
Owner

momocow commented Jan 19, 2023

The first thing that should be found out is why :hammer: did not match anything from gitmojis package.

I'll try to reproduce it first.

@momocow momocow mentioned this pull request Jan 24, 2023
Closed
@momocow momocow changed the base branch from master to dev January 24, 2023 17:28
@momocow momocow merged commit 37f6964 into momocow:dev Jan 24, 2023
momocow added a commit that referenced this pull request Jan 24, 2023
@bryanjtc @momocow @inazuma-bot
🐛 fix: Fixed type error (#58)
15d3e91 
* 🔖 v1.4.5 [skip ci]

https://github.com/momocow/semantic-release-gitmoji/releases/tag/v1.4.5

* 🔖 v1.5.0 [skip ci]

https://github.com/momocow/semantic-release-gitmoji/releases/tag/v1.5.0

* 🔖 v1.6.0 [skip ci]

https://github.com/momocow/semantic-release-gitmoji/releases/tag/v1.6.0

* 🐛 fix: Fixed type error

Co-authored-by: 牛牛 <momocow.me@gmail.com>
Co-authored-by: 電ちゃん <inazuma.love.225@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] TypeError: Cannot read properties of undefined (reading 'semver')
3 participants
@bryanjtc @momocow @inazuma-bot