2
2
3
3
<!-- toc -->
4
4
5
- There are _ a lot_ of ways to contribute to the rust compiler, including fixing
5
+ There are _ a lot_ of ways to contribute to the Rust compiler, including fixing
6
6
bugs, improving performance, helping design features, providing feedback on
7
7
existing features, etc. This chapter does not claim to scratch the surface.
8
8
Instead, it walks through the design and implementation of a new feature. Not
@@ -38,7 +38,7 @@ fn main() {
38
38
So basically, the ` $(pat)? ` matcher in the macro means "this pattern can occur
39
39
0 or 1 times", similar to other regex syntaxes.
40
40
41
- There were a number of steps to go from an idea to stable rust feature. Here is
41
+ There were a number of steps to go from an idea to stable Rust feature. Here is
42
42
a quick list. We will go through each of these in order below. As I mentioned
43
43
before, not all of these are needed for every type of contribution.
44
44
@@ -55,9 +55,9 @@ before, not all of these are needed for every type of contribution.
55
55
feature on the nightly compiler and in ` std ` , there may be additional
56
56
feedback about design choice that might be adjusted. This particular feature
57
57
went [ through] [ impl2 ] a [ number] [ impl3 ] of [ iterations] [ impl4 ] .
58
- - ** Stabilization** When your feature has baked enough, a rust team member may
58
+ - ** Stabilization** When your feature has baked enough, a Rust team member may
59
59
[ propose to stabilize it] [ merge ] . If there is consensus, this is done.
60
- - ** Relax** Your feature is now a stable rust feature!
60
+ - ** Relax** Your feature is now a stable Rust feature!
61
61
62
62
[ prerfc ] : https://internals.rust-lang.org/t/pre-rfc-at-most-one-repetition-macro-patterns/6557
63
63
[ rfc ] : https://github.com/rust-lang/rfcs/pull/2298
@@ -70,7 +70,7 @@ before, not all of these are needed for every type of contribution.
70
70
## Pre-RFC and RFC
71
71
72
72
> NOTE: In general, if you are not proposing a _ new_ feature or substantial
73
- > change to rust or the ecosystem, you don't need to follow the RFC process.
73
+ > change to Rust or the ecosystem, you don't need to follow the RFC process.
74
74
> Instead, you can just jump to [ implementation] ( #impl ) .
75
75
>
76
76
> You can find the official guidelines for when to open an RFC [ here] [ rfcwhen ] .
@@ -79,7 +79,7 @@ before, not all of these are needed for every type of contribution.
79
79
80
80
An RFC is a document that describes the feature or change you are proposing in
81
81
detail. Anyone can write an RFC; the process is the same for everyone,
82
- including rust team members.
82
+ including Rust team members.
83
83
84
84
To open an RFC, open a PR on the
85
85
[ rust-lang/rfcs] ( https://github.com/rust-lang/rfcs ) repo on GitHub. You can
@@ -122,7 +122,7 @@ itself to reflect the course of the discussion (e.g. new alternatives or prior
122
122
work may be added or you may decide to change parts of the proposal itself).
123
123
124
124
In the end, when the discussion seems to reach a consensus and die down a bit,
125
- a rust team member may propose to move to "final comment period" (FCP) with one
125
+ a Rust team member may propose to move to "final comment period" (FCP) with one
126
126
of three possible dispositions. This means that they want the other members of
127
127
the appropriate teams to review and comment on the RFC. More discussion may
128
128
ensue, which may result in more changes or unresolved questions being added. At
@@ -137,7 +137,7 @@ disposition is adopted. Here are the three possible dispositions:
137
137
This is not a reflection on you, but rather a community decision that rust
138
138
will go a different direction.
139
139
- _ Postpone_ : there is interest in going this direction but not at the moment.
140
- This happens most often because the appropriate rust team doesn't have the
140
+ This happens most often because the appropriate Rust team doesn't have the
141
141
bandwidth to shepherd the feature through the process to stabilization. Often
142
142
this is the case when the feature doesn't fit into the team's roadmap.
143
143
Postponed ideas may be revisited later.
@@ -181,7 +181,7 @@ gate is removed when the feature is stabilized.
181
181
make your changes/improvements.
182
182
183
183
When you open a PR on the [ rust-lang/rust] , a bot will assign your PR to a
184
- review. If there is a particular rust team member you are working with, you can
184
+ review. If there is a particular Rust team member you are working with, you can
185
185
request that reviewer by leaving a comment on the thread with `r?
186
186
@reviewer-github -id` (e.g. ` r? @eddyb`). If you don't know who to request,
187
187
don't request anyone; the bot will assign someone automatically based on which files you changed.
@@ -224,7 +224,7 @@ be proposed and unresolved questions may become resolved. Updates/changes go
224
224
through the same process for implementing any other changes, as described
225
225
above (i.e. submit a PR, go through review, wait for ` @bors ` , etc).
226
226
227
- Some changes may be major enough to require an FCP and some review by rust team
227
+ Some changes may be major enough to require an FCP and some review by Rust team
228
228
members.
229
229
230
230
For the ` ? ` macro feature, we went through a few different iterations after the
0 commit comments