fix(MenuItem): split menu items does not open sub-menu when navigating directly between two split menus #1904
Conversation
| splitMenuItemIconButtonRef, | ||
| index, | ||
| hasChildren, | ||
| splitMenuItem, | ||
| isMouseEnterOnIconButton, | ||
| prevIsMouseEnterOnIconButton, | ||
| isActive, | ||
| resetOpenSubMenuIndex, | ||
| setActiveItemIndex, | ||
| isMouseEnter |
There was a problem hiding this comment.
removed unused dependencies
YossiSaadi
changed the title
|
@YuliaGold I think you are experiencing a different issue.
|
|
@YossiSaadi yeah i know that it doesn't reproduce in storybook |
@YuliaGold if it works on an isolated environment, it probably means the bug is not with the component |
|
@YossiSaadi |
@YuliaGold I mean something I can play with and investigate |
|
@YossiSaadi ohhh, |
if it's already on staging/prod with FF then even better if I don't need the MF. |
There was a problem hiding this comment.
@YuliaGold I think that just removing line 59 will result in the same effect
There was a problem hiding this comment.
@talkor hey, i tried but it didn't make any affect
There was a problem hiding this comment.
@talkor @YossiSaadi hey do you have any updates?
There was a problem hiding this comment.
@YuliaGold the issue doesn't reproduce for me
Screen.Recording.2024-01-28.at.10.46.14.mp4
|
Verified in React 18.2, @YuliaGold please try this prerelease, should resolve this issue anyway |
talkor
deleted the
yulia/bug-movement_between_split_menu_items_wont_open_sub_menu
branch
https://monday.monday.com/boards/2520706822/pulses/5699284655
split menu item doesn't open consistently when hovering between menu items.
isActive is not turning to true even though the mouse is over the correct menu item.
isActive ---> index === activeIndex ---> true
looks like there is missing a render cycle for the menu item in order to update the isActive value so that hover on the split menu item will result in opening the sub menu.
before:
after:
