Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add issue template form #1913

Merged
merged 3 commits into from
Jan 29, 2024
Merged

chore: add issue template form #1913

merged 3 commits into from
Jan 29, 2024

Conversation

talkor
Copy link
Member

@talkor talkor commented Jan 22, 2024

This will help us get more useful info when opening an issue or requesting for a feature. It will add button for each when you open a new issue
https://monday.monday.com/boards/3532714909/pulses/5901525815

@talkor talkor requested a review from a team as a code owner January 22, 2024 08:19
Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there's a new Issue Form feature, might worth consider in a future iteration on that
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-forms

It is very powerful in compare to the markdown

name: Feature request
about: Suggest an idea
title: ''
labels: ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a suitable label maybe so we can filter?

---
name: Feature request
about: Suggest an idea
title: ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: ''
title: ''[Feature]: "

maybe something like this

---
name: Bug report
about: Create a bug report
title: ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: ''
title: ''[Bug]: "

here also, maybe something like this

Browser, operating system

**Reproducible Example**
Please provide a simple minimal example that reproduces the issue. Use this [StackBlitz](https://stackblitz.com/edit/vibe-bug-report) or anything similar.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

If applicable, add screenshots or a video to help explain your problem.

**Package Version**
e.g. 2.84.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm being picky here, sorry, but for consistency: you ended the other sentences with a dot, so maybe worth here also

Suggested change
e.g. 2.84.0
e.g. 2.84.0 .

e.g. 2.84.0

**System Info**
Browser, operating system
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm being picky here, sorry, but for consistency: you ended the other sentences with a dot, so maybe worth here also

Suggested change
Browser, operating system
Browser, operating system.

---

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm being picky here, sorry, but for consistency: you ended the other sentences with a dot, so maybe worth here also

Suggested change
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...].


---

**Is your feature request related to a problem? Please describe.**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm being picky here, sorry, but for consistency: you ended the other headline without a dot, so maybe worth here also

Suggested change
**Is your feature request related to a problem? Please describe.**
**Is your feature request related to a problem? Please describe**

@talkor talkor changed the title chore: add issue templates chore: add issue template form Jan 28, 2024
@talkor
Copy link
Member Author

talkor commented Jan 28, 2024

I see there's a new Issue Form feature, might worth consider in a future iteration on that https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-forms

It is very powerful in compare to the markdown

I went with the form eventually, really liked it. I saw in many projects that feature requests are directed to Discussions instead of Issues which seems legit and helps keeping issue just for bugs, I liked it, would love to hear some thoughts

@talkor talkor requested review from a team and shaharzil January 28, 2024 16:12
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
@talkor talkor merged commit 3117717 into master Jan 29, 2024
11 checks passed
@talkor talkor deleted the chore/issue-tempaltes branch January 29, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants