Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add email TextFieldTextType #1916

Merged
merged 2 commits into from
Jan 25, 2024
Merged

feat: add email TextFieldTextType #1916

merged 2 commits into from
Jan 25, 2024

Conversation

or-nuri-monday
Copy link
Contributor

Basic

  • Used plop (npm run plop) to create a new component.
  • PR has description.
  • New component is functional and uses Hooks.
  • Component is written in TypeScript.

Style

  • Styles are added to NewComponent.modules.scss file inside the NewComponent folder.
  • Component uses CSS Modules.
  • Design is compatible with Monday Design System.
  • Styles are defined using monday-ui-style tokens
  • Displays correctly in all the themes

Storybook

  • Stories were added to /src/components/NewComponent/__stories__/NewComponent.mdx file.
  • Stories include all flows of using the component.
  • Stories implemented using vibe-storybook-components components and tokens.

Tests

Accessibility

@or-nuri-monday or-nuri-monday requested a review from a team as a code owner January 25, 2024 10:55
@or-nuri-monday or-nuri-monday added enhancement New feature or request feature and removed enhancement New feature or request labels Jan 25, 2024
@shaharzil
Copy link
Contributor

shaharzil commented Jan 25, 2024 •
edited
Loading

Awesome!

@shaharzil shaharzil merged commit 6bfda79 into mondaycom:master Jan 25, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaharzil shaharzil shaharzil approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@or-nuri-monday @shaharzil