feat(MenuItem): be able to provide a component to title #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talkor
commented
Feb 8, 2024
| } | ||
|
|
||
| const MenuItem: VibeComponent<MenuItemProps> & { | ||
| interface MenuItemTitleComponentProps extends Omit<MenuItemProps, "title"> { |
There was a problem hiding this comment.
@YossiSaadi changed it eventually because MenuItemProps is exported so it breaks stuff
YossiSaadi
reviewed
Feb 8, 2024
| @@ -220,6 +237,8 @@ const MenuItem: VibeComponent<MenuItemProps> & { | |||
| [setSubMenuIsOpenByIndex, index, closeMenu] | |||
| ); | |||
|
|
|||
| const iconLabel = typeof title === "string" ? title : ariaLabel; | |||
|
|
|||
| const renderSubMenuIconIfNeeded = () => { | |||
| if (!hasChildren) return null; | |||
There was a problem hiding this comment.
I would say not to take title's type into account. aria || title
There was a problem hiding this comment.
it fails TS, it's not smart enough
YossiSaadi
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/pulses/6027956948