Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support on menu button "tooltip content" and "class name" props and tipseen "move by" #308

Merged
merged 10 commits into from
Oct 31, 2021

Conversation

hadasfa
Copy link
Contributor

@hadasfa hadasfa commented Oct 31, 2021

Go over this checklist before submitting your Pull Request

Description: add support on menu button "tooltip content" and "class name" props while still keep backward compatibility for the old naming

Updating existing component

Basic

  • [v] PR has description
  • Changes to the component are backward compatible (including selectors structure). If not - add to the title of the PR "BREAKABLE_CHANGE""
  • [ v] All changes to the component are reflected in the ReadMe
  • [v ] If component is old and was not compliant with the latest guidelines - it was fixed (optional)

Style

Storybook

  • [ v] All the changes to the component should be reflected in the Storybook.
  • [ v] Component passed Accessibility Plugin checks

Tests

  • [ v] All current tests are passing
  • [ v] New functionality is covered with tests
  • [ v] Tests are compliant with TESTING_README.md instructions

@hadasfa hadasfa changed the title add support on menu button "tooltip content" and "class name" props add support on menu button "tooltip content" and "class name" props and tipseen "move by" Oct 31, 2021
Co-authored-by: Moshe Zemah <moshe@monday.com>
@hadasfa hadasfa merged commit 9e69664 into master Oct 31, 2021
@hadasfa hadasfa deleted the naming/hadas/menu-button branch October 31, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants