Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix : scroll menu if needed #426

Merged
merged 4 commits into from
Jan 4, 2022
Merged

Bugfix : scroll menu if needed #426

merged 4 commits into from
Jan 4, 2022

Conversation

amirbardugo
Copy link
Contributor

As we talked about now you can pass arg to menu that will scroll to the active menu item if needed

Basic

  • Used plop (npm run plop) to create a new component.
  • PR has description.
  • New component is functional and uses Hooks.
  • Component defines PropTypes.

Style

  • Styles are added to NewComponent.modules.scss file inside of the NewComponent folder.
  • Component uses CSS Modules.
  • Design is compatible with Monday Design System.

Storybook

  • Stories were added to /src/NewComponent/__stories__/NewComponent.stories.js file.
  • Stories include all flows of using the component.

Tests

@amirbardugo amirbardugo changed the title scroll menu if needed Bugfix : scroll menu if needed Jan 3, 2022
@orrgottlieb orrgottlieb merged commit 1ccfdea into master Jan 4, 2022
@orrgottlieb orrgottlieb deleted the amir/fix/menu-should-scroll-if-needed branch January 4, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orrgottlieb orrgottlieb orrgottlieb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amirbardugo @orrgottlieb