Menu enhancements #502
Merged
Menu enhancements #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laviomri
commented
Jan 30, 2022
|
|
||
| const NAVIGATION_KEYS = [...ARROW_UP_KEYS, ...ARROW_RIGHT_KEYS, ...ARROW_DOWN_KEYS, ...ARROW_LEFT_KEYS]; | ||
|
|
||
| export const useLastNavigationDirection = () => { |
There was a problem hiding this comment.
This will be used in the new MenuGridItem, to detect the direction of menu navigation.
Basically I can use it in more existing places and save some code and complexity - maybe I'll do it when I have some time
laviomri
commented
Jan 30, 2022
| @@ -226,6 +232,7 @@ const MenuItem = forwardRef( | |||
| aria-current={isActive} | |||
| onMouseLeave={onMouseLeave} | |||
| onMouseEnter={onMouseEnter} | |||
| tabIndex={-1} | |||
There was a problem hiding this comment.
there are many manipulation of focus/blur, it's much easier when each menu item is focusable
There was a problem hiding this comment.
Very small suggestion - -1 kinda feels like a "magic" number, maybe assign it to a constant with a meaningful name?
…to feature/omri/menu-enhancements
sahariko
approved these changes
Feb 1, 2022
| @@ -226,6 +232,7 @@ const MenuItem = forwardRef( | |||
| aria-current={isActive} | |||
| onMouseLeave={onMouseLeave} | |||
| onMouseEnter={onMouseEnter} | |||
| tabIndex={-1} | |||
There was a problem hiding this comment.
Very small suggestion - -1 kinda feels like a "magic" number, maybe assign it to a constant with a meaningful name?
|
@sahariko applied your suggestion 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Small improvements and additions around the
Menucomponents. I split it to avoid a larger PR for the incomingMenuGridItem.