Allow non-monday colors picker #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orrgottlieb
approved these changes
Feb 3, 2022
| import PropTypes from "prop-types"; | ||
| import cx from "classnames"; | ||
| import NOOP from "lodash/noop"; | ||
| import { COLOR_STYLES } from "../../../../general-stories/colors/colors-vars-map"; | ||
| import { COLOR_STYLES, contentColors } from "../../../../general-stories/colors/colors-vars-map"; |
There was a problem hiding this comment.
can we move these to something not related to stories ?
There was a problem hiding this comment.
I'm not sure I understand you correctly - right now it's not related to storybook. what are you suggesting?
There was a problem hiding this comment.
I think it's about to move this constants to different location which not related to stories, maybe the colors util?
There was a problem hiding this comment.
oh I see it now! done
hadasfa
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Allows non-monday colors to be rendered in the color picker.
Why? Since sometimes we need to color picker for existing colors, that aren't part of our "official" palette. (e.g. on the workspace color picker).
I want to discourage the usage of this flag, so I named it in accordingly (the word "force.." always makes you think twice 😄 ).
Also, I intentionally didn't add a story, since I don't want it to be too familiar.