Better support for useDocumentEventListeners on Menu components #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laviomri
commented
Feb 17, 2022
| @@ -130,10 +130,11 @@ const MenuItem = forwardRef( | |||
| }, [shouldShowSubMenu, childElement, useDocumentEventListeners]); | |||
|
|
|||
| useEffect(() => { | |||
| if (useDocumentEventListeners) return; | |||
There was a problem hiding this comment.
This is the most important part
orrgottlieb
approved these changes
Feb 20, 2022
laviomri
deleted the
fix/omri/fix-support-for-useDocumentEventListeners
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
I've added better handling for
useDocumentEventListeners. On other Menu-related components, most of the handlers are being disabled whenuseDocumentEventListeners = true. I've matched the critical paths' behavior, to avoid stealing the focus when not intended.NOTE:
MenuGridItemwill not work properly whenuseDocumentEventListeners = true, since most of the handlers will now be turned off. I assume here that there's no such use case yet, sinceMenuGridItemis very new, anduseDocumentEventListenersis rarely used.