Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dropdown groups to storybook and change dropdown groups style #562

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Add dropdown groups to storybook and change dropdown groups style #562

merged 1 commit into from
Mar 10, 2022

Conversation

RonNachmany
Copy link
Contributor

@RonNachmany RonNachmany commented Feb 28, 2022 •
edited
Loading

Add dropdown groups to storybook and change style.

image (12)

Basic

  • Used plop (npm run plop) to create a new component.
  • PR has description.
  • New component is functional and uses Hooks.
  • Component defines PropTypes.

Style

  • Styles are added to NewComponent.modules.scss file inside of the NewComponent folder.
  • Component uses CSS Modules.
  • Design is compatible with Monday Design System.

Storybook

  • Stories were added to /src/NewComponent/__stories__/NewComponent.stories.js file.
  • Stories include all flows of using the component.

Tests

@RonNachmany RonNachmany self-assigned this Feb 28, 2022
@RonNachmany RonNachmany requested review from mentaman and hadasfa and removed request for hadasfa and mentaman February 28, 2022 13:30
hadasfa
hadasfa suggested changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@hadasfa hadasfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please replace usage of css variables for font size, add picture to the PR and check with evigany about the 14px font size

@hadasfa hadasfa self-requested a review March 10, 2022 08:28
@hadasfa hadasfa merged commit 65a7251 into master Mar 10, 2022
@hadasfa hadasfa deleted the dropdown-with-groups branch March 10, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadasfa hadasfa hadasfa approved these changes

@mentaman mentaman mentaman approved these changes

Assignees

@RonNachmany RonNachmany

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RonNachmany @mentaman @hadasfa