-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(slider): add Thumb drag interaction tests #610
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add interaction helper drag - add prototype of test for Thumb drag
niksa-monday
changed the title
test(slider): try to add mouse drag tests
draft: test(slider): try to add mouse drag tests
Mar 29, 2022
- change mouse event to pointer events according to Slider code
…n-tests-slider-thumb # Conflicts: # src/components/Slider/__tests__/Slider.interactions.js
- switch from 1/4, 3/4, etc. to more clear 0.25, 0.75 etc.
- minor changes at drag utils - make order and finalize drag Slider Thumb tests
niksa-monday
changed the title
draft: test(slider): try to add mouse drag tests
test(slider): try to add mouse drag tests
Mar 30, 2022
niksa-monday
changed the title
test(slider): try to add mouse drag tests
test(slider): add Thumb drag interaction tests
Mar 30, 2022
laviomri
approved these changes
Mar 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks very cool! had a few comments, for your discretion :)
- minor refactoring of prev tests (change name and add some comments) - add simple Thumbs drag interaction tests for Ranged Slider - add Cross Start/End Thumbs tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add interaction tests with Mouse(Pointer) Drag interaction tests for Slider.
Mouse down on Thumb and then move it for change value of Slider.
Some links I used as basis for PR:
https://testing-library.com/docs/example-drag/
testing-library/user-event#440