Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix Windows platform detection #4902

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Nov 20, 2024

When running locally, collect all the data we need.

When running locally, collect all the data we need.

Signed-off-by: Christian Zunker <christian@mondoo.com>
@czunker
Copy link
Contributor Author

czunker commented Nov 20, 2024

Before:
Screenshot from 2024-11-20 13-24-42

After:
Screenshot from 2024-11-20 16-09-56

Copy link
Contributor

Test Results

3 146 tests  ±0   3 145 ✅ ±0   1m 29s ⏱️ +2s
  371 suites ±0       1 💤 ±0 
   28 files   ±0       0 ❌ ±0 

Results for commit 4fea8ca. ± Comparison against base commit d46d864.

Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @czunker

@chris-rock chris-rock merged commit c10e069 into main Nov 20, 2024
16 checks passed
@chris-rock chris-rock deleted the czunker/fix_win_platform branch November 20, 2024 20:07
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants