Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for forks can be skipped #720

Open
imilchev opened this issue Dec 8, 2022 · 0 comments
Open

Tests for forks can be skipped #720

imilchev opened this issue Dec 8, 2022 · 0 comments

Comments

@imilchev
Copy link
Member

imilchev commented Dec 8, 2022

Currently, if a PR is opened from a fork the integration tests are skipped. They can be triggered by labeling the PR. This works correctly, however, it also means we can forget to run those tests. I propose to make the pipeline fail if the tests haven't run for the PR. This makes sure we cannot merge the PR without running the tests in the first place.

I took our approach and applied it to another repo. I modified it a bit there to also add a comment to the PR regarding the tests and to make sure by default the workflow is failed instead of skipped. See podkrepi-bg/frontend#1243 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant