Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

Upcoming hard fork [view tags?] #113

Closed
plowsof opened this issue Apr 20, 2022 · 8 comments
Closed

Upcoming hard fork [view tags?] #113

plowsof opened this issue Apr 20, 2022 · 8 comments

Comments

@plowsof
Copy link
Contributor

plowsof commented Apr 20, 2022

Hello, the upcoming Monero hard fork will be introducing view-tags

It would be nice to have this supported by the outputs function

@emesik
Copy link
Contributor

emesik commented Apr 20, 2022

I agree it would be great. Anyone willing to submit a PR?

@plowsof
Copy link
Contributor Author

plowsof commented Apr 20, 2022

I reached out to @j-berman who confirms that the json will appear as :

{ 
  "target": {
    "tagged_key": {
      "key": "ea3f...",
      "view_tag": "a1"
    }
  }
}

and offered his initial suggestion of how it may end up looking like - and because older transactions will not have view_tags, we must try: if one is set first. An implementation / work in progress of which can be found here

It would be also really nice to have some benchmarks done with a working implementation / simulated 'view_tag' block data, my guess is the scan time might be sped up more than 40% in python.

The PR i have made is to get the ball rolling. We can test it on testnet next month :) - i believe you are using the json-rpc wallet to construct a transaction? so i think no changes will be needed other than to support the view tags in finding outputs (i hope)

@emesik
Copy link
Contributor

emesik commented Apr 27, 2022

What is the height/date of scheduled release to the testnet?

@emesik
Copy link
Contributor

emesik commented Apr 27, 2022

So far, I rebased it and merged into the viewtags branch.

@plowsof
Copy link
Contributor Author

plowsof commented Apr 28, 2022

Thanks!

I have read that it is usually 1 month prior to the hard fork date , so we would expect it to be 16th June, but i will confirm those details for you.

Testnet fork height will be decided in the next dev meeting monero-project/meta#700

@plowsof
Copy link
Contributor Author

plowsof commented May 7, 2022

Testnet hard-fork: May 16th, 2022, block 1982800 and 1983520
Stagenet hard-fork: July 9th
Mainnet hard-fork: July 16th, 2022, block 2668888

@emesik
Copy link
Contributor

emesik commented May 9, 2022

Thank you! I'm adding these dates into my calendar.

@emesik
Copy link
Contributor

emesik commented Sep 27, 2022

Merged and released

@emesik emesik closed this as completed Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants