Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet2::import_multisig doesn't signal about error if refresh failed #4359

Closed
naughtyfox opened this issue Sep 10, 2018 · 1 comment
Closed
Labels

Comments

@naughtyfox
Copy link
Contributor

naughtyfox commented Sep 10, 2018

We encountered the following bug - if refresh error happens like wallet disconnected from daemon when multisig wallets exchange with multisig key images wallet2::import_multisig function does not indicate that operation is failed. Client code cannot determine if operation has been successful. This happens because sync exception just captured and wasn't propogated to the calling code (

catch (...) {}
).

This kind of error occurs especially often on mobile devices where connectivity may be not stable.

@moneromooo-monero
Copy link
Collaborator

+resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants