-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The develop command doesn't obey service dependencies #61
Comments
So I found the culprit https://github.com/momentumft/navy/blob/master/packages/navy/src/cli/develop.js#L59 Would seem this is intentional. |
@madjam002 do you remember why you implemented it this way? |
@tanuck What's the use case here? Why (in your example above) do you need the db service to relaunch in the event of you developing an app service? |
Don't want it to relaunch... the problem is if it isn't running when you
|
Ah yeah fair enough. The main reason nodeps was added is because sometimes developing a service which was heavily depended upon would cause like ~10 services to relaunch which sometimes takes quite a while. |
So |
Sounds good. Maybe it's a good idea to try changing the default in a beta or behind a feature flag to trial it? |
If service A
depends_on
service B in your compose file (i.e. a app servicedepends_on
db service) and you then runnavy develop
on service A, the dependency will be ignored. I haven't looked into why yet.@madjam002 was this the intended behaviour?
The text was updated successfully, but these errors were encountered: