Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The develop command doesn't obey service dependencies #61

Open
tanuck opened this issue Apr 25, 2017 · 7 comments
Open

The develop command doesn't obey service dependencies #61

tanuck opened this issue Apr 25, 2017 · 7 comments
Assignees

Comments

@tanuck
Copy link
Contributor

tanuck commented Apr 25, 2017

If service A depends_on service B in your compose file (i.e. a app service depends_on db service) and you then run navy develop on service A, the dependency will be ignored. I haven't looked into why yet.

@madjam002 was this the intended behaviour?

@tanuck tanuck self-assigned this Apr 25, 2017
@tanuck
Copy link
Contributor Author

tanuck commented Apr 25, 2017

So I found the culprit https://github.com/momentumft/navy/blob/master/packages/navy/src/cli/develop.js#L59

Would seem this is intentional.

@tanuck
Copy link
Contributor Author

tanuck commented Apr 27, 2017

@madjam002 do you remember why you implemented it this way?

@madjam002
Copy link
Contributor

@tanuck What's the use case here? Why (in your example above) do you need the db service to relaunch in the event of you developing an app service?

@tanuck
Copy link
Contributor Author

tanuck commented Apr 27, 2017

Don't want it to relaunch... the problem is if it isn't running when you navy develop your service. I.e do the following:

  1. navy kill
  2. navy ps returns zero running services
  3. navy develop your app service - now the depended upon service isn't running for your app service

@madjam002
Copy link
Contributor

Ah yeah fair enough. The main reason nodeps was added is because sometimes developing a service which was heavily depended upon would cause like ~10 services to relaunch which sometimes takes quite a while.

@ThomWright
Copy link
Contributor

So nodeps is really useful especially for running single-service tests, but it should probably default to false in every case, rather than sometimes true, sometimes false.

@madjam002
Copy link
Contributor

Sounds good. Maybe it's a good idea to try changing the default in a beta or behind a feature flag to trial it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants