Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

touch should be supported #71

Open
evictor opened this issue Dec 14, 2019 · 0 comments
Open

touch should be supported #71

evictor opened this issue Dec 14, 2019 · 0 comments

Comments

@evictor
Copy link

evictor commented Dec 14, 2019

I'm aware of this closed issue regarding resave: #24

I would like support in this plugin for the touch method to avoid having to use resave: true. The reason is that the latter is not safe when many requests might be happening at once against the same session, which is not uncommon for a Web app with a bunch of async XHRs firing at once on a page.

It's very difficult to prove but I (and some of my product's users) believe I have witnessed this in practice with symptoms of race condition-type problems related to session saving.

Touch support should be easy, I imagine; is it no just updating some sort of "last active" timestamp in the DB? I wouldn't mind submitting a PR as such...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant