fix(with-transaction): throw a useful error on invalid return type

Author: mbroadst

lib/sessions.js

@@ -11,6 +11,7 @@ const MongoNetworkError = require('./error').MongoNetworkError;
 const MongoWriteConcernError = require('./error').MongoWriteConcernError;
 const Transaction = require('./transactions').Transaction;
 const TxnState = require('./transactions').TxnState;
+const isPromiseLike = require('./utils').isPromiseLike;
 
 function assertAlive(session, callback) {
   if (session.serverSession == null) {
@@ -328,7 +329,19 @@ function userExplicitlyEndedTransaction(session) {
 function attemptTransaction(session, startTime, fn, options) {
   session.startTransaction(options);
 
-  return fn(session)
+  let promise;
+  try {
+    promise = fn(session);
+  } catch (err) {
+    promise = Promise.reject(err);
+  }
+
+  if (!isPromiseLike(promise)) {
+    session.abortTransaction();
+    throw new TypeError('Function provided to `withTransaction` must return a Promise');
+  }
+
+  return promise
     .then(() => {
       if (userExplicitlyEndedTransaction(session)) {
         return;

lib/utils.js

@@ -106,12 +106,23 @@ function collationNotSupported(server, cmd) {
   return cmd && cmd.collation && maxWireVersion(server) < 5;
 }
 
+/**
+ * Checks if a given value is a Promise
+ *
+ * @param {*} maybePromise
+ * @return true if the provided value is a Promise
+ */
+function isPromiseLike(maybePromise) {
+  return maybePromise && typeof maybePromise.then === 'function';
+}
+
 module.exports = {
   uuidV4,
   calculateDurationInMs,
   relayEvents,
   collationNotSupported,
   retrieveEJSON,
   retrieveKerberos,
-  maxWireVersion
+  maxWireVersion,
+  isPromiseLike
 };