chore: improvements based on PR comments

Author: kmruiz

src/common/search/embeddingsProvider.ts

@@ -42,7 +42,7 @@ class VoyageEmbeddingsProvider implements EmbeddingsProvider<VoyageModels, Voyag
     private readonly voyage: VoyageProvider;
 
     constructor({ voyageApiKey }: UserConfig, providedFetch?: typeof fetch) {
-        assert(voyageApiKey, "voyageApiKey does not exist. This is likely a bug.");
+        assert(voyageApiKey, "The VoyageAI API Key does not exist. This is likely a bug.");
 
         // We should always use, by default, any enterprise proxy that the user has configured.
         // Direct requests to VoyageAI might get blocked by the network if they don't go through

src/common/search/vectorSearchEmbeddingsManager.ts

@@ -55,7 +55,7 @@ export class VectorSearchEmbeddingsManager {
         database: string;
         collection: string;
     }): Promise<VectorFieldIndexDefinition[]> {
-        const provider = await this.assertAtlasSearchIsAvailable();
+        const provider = await this.atlasSearchEnabledProvider();
         if (!provider) {
             return [];
         }
@@ -94,7 +94,7 @@ export class VectorSearchEmbeddingsManager {
         },
         document: Document
     ): Promise<VectorFieldValidationError[]> {
-        const provider = await this.assertAtlasSearchIsAvailable();
+        const provider = await this.atlasSearchEnabledProvider();
         if (!provider) {
             return [];
         }
@@ -112,7 +112,7 @@ export class VectorSearchEmbeddingsManager {
             .filter((e) => e !== undefined);
     }
 
-    private async assertAtlasSearchIsAvailable(): Promise<NodeDriverServiceProvider | null> {
+    private async atlasSearchEnabledProvider(): Promise<NodeDriverServiceProvider | null> {
         const connectionState = this.connectionManager.currentConnectionState;
         if (connectionState.tag === "connected" && (await connectionState.isSearchSupported())) {
             return connectionState.serviceProvider;
@@ -235,7 +235,7 @@ export class VectorSearchEmbeddingsManager {
         embeddingParameters: SupportedEmbeddingParameters;
         inputType: EmbeddingParameters["inputType"];
     }): Promise<unknown[]> {
-        const provider = await this.assertAtlasSearchIsAvailable();
+        const provider = await this.atlasSearchEnabledProvider();
         if (!provider) {
             throw new MongoDBError(
                 ErrorCodes.AtlasSearchNotSupported,