Skip to content

feat(NODE-4592): add type defs for wrapped methods #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2022
Merged

feat(NODE-4592): add type defs for wrapped methods #3

merged 1 commit into from
Sep 1, 2022

Conversation

nbbeeken
Copy link
Collaborator

@nbbeeken nbbeeken commented Aug 18, 2022 •
edited
Loading

  • Add type definitions that inherit from the driver
  • Rename the legacy exports to the expected ones from the driver
  • use export * for everything else

NODE-4592

@nbbeeken nbbeeken changed the base branch from main to test/NODE-4520/maybe_callback August 18, 2022 19:52
@nbbeeken nbbeeken force-pushed the test/NODE-4520/maybe_callback branch 2 times, most recently from b59790c to 6a11426 Compare August 18, 2022 21:47
@nbbeeken nbbeeken force-pushed the types/NODE-4520/add-definitions branch from 2050961 to 8e33df4 Compare August 18, 2022 21:48
@nbbeeken nbbeeken force-pushed the test/NODE-4520/maybe_callback branch from 6a11426 to b1ab63e Compare August 20, 2022 01:26
@nbbeeken nbbeeken force-pushed the types/NODE-4520/add-definitions branch from 8e33df4 to 6f82794 Compare August 20, 2022 01:35
@nbbeeken nbbeeken changed the base branch from test/NODE-4520/maybe_callback to main August 20, 2022 01:36
@nbbeeken nbbeeken force-pushed the types/NODE-4520/add-definitions branch from 6f82794 to 537f564 Compare August 20, 2022 02:00
@nbbeeken nbbeeken force-pushed the types/NODE-4520/add-definitions branch from 537f564 to bd6eaa9 Compare August 29, 2022 14:29
@nbbeeken nbbeeken marked this pull request as ready for review August 29, 2022 14:30
@nbbeeken nbbeeken changed the title feat(NODE-4520): add type defs for wrapped methods feat(NODE-4592): add type defs for wrapped methods Aug 29, 2022
@dariakp dariakp merged commit d59a002 into main Sep 1, 2022
@dariakp dariakp deleted the types/NODE-4520/add-definitions branch September 1, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

Assignees
No one assigned
Labels
Team Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @dariakp