Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-6590): add build for x64 macos #45

Merged
merged 9 commits into from
Dec 4, 2024
Merged

fix(NODE-6590): add build for x64 macos #45

merged 9 commits into from
Dec 4, 2024

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Dec 2, 2024 •
edited
Loading

Description

What is changing?

We don't build and publish a macos x64 prebuild

  • publish the arm64 build as the x64 build (same as mongodb-client-encryption)
  • make the arm64 build a universal binary (same as mongodb-client-encryption)

the entrypoint for the package points to the wrong file

  • update main in the package.json to lib/index.js

the gypfile is not included in the package

  • ensure all files are included in the package
Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run format:js && npm run format:rs script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title ensure all relevant files are included in release fix(NODE-6572): misc fixes from 2.0.0-alpha.0 Dec 2, 2024
@baileympearson baileympearson marked this pull request as ready for review December 2, 2024 16:42
nbbeeken
nbbeeken reviewed Dec 2, 2024
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
etc/make-macos-x64-build.sh Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
nbbeeken
nbbeeken reviewed Dec 2, 2024
View reviewed changes
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
@dariakp dariakp changed the title fix(NODE-6572): misc fixes from 2.0.0-alpha.0 fix(NODE-6590): misc fixes from 2.0.0-alpha.0 Dec 3, 2024
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Dec 3, 2024
@baileympearson baileympearson changed the title fix(NODE-6590): misc fixes from 2.0.0-alpha.0 fix(NODE-6590): add build for x64 macos Dec 3, 2024
nbbeeken
nbbeeken requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small quick one, otherwise lgtm

etc/install-zstd.sh Show resolved Hide resolved
nbbeeken
nbbeeken previously requested changes Dec 4, 2024
View reviewed changes
etc/install-zstd.sh Outdated Show resolved Hide resolved
@baileympearson baileympearson dismissed nbbeeken’s stale review December 4, 2024 17:46

Follow-up ticket filed.

@nbbeeken nbbeeken merged commit 4972129 into main Dec 4, 2024
37 checks passed
@nbbeeken nbbeeken deleted the alpha-fixes branch December 4, 2024 17:58
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Merged
@baileympearson baileympearson mentioned this pull request Dec 5, 2024
Merged
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
Merged
@baileympearson baileympearson mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baileympearson @nbbeeken @dariakp