fix(_bsontype): only check bsontype if it is a prototype member.

Author: daprahamian

lib/bson/binary.js

@@ -40,8 +40,6 @@ function Binary(buffer, subType) {
     throw new Error('only String, Buffer, Uint8Array or Array accepted');
   }
 
-  this._bsontype = 'Binary';
-
   if (buffer instanceof Number) {
     this.sub_type = buffer;
     this.position = 0;
@@ -81,6 +79,11 @@ function Binary(buffer, subType) {
   }
 }
 
+Object.defineProperty(Binary.prototype, '_bsontype', {
+  value: 'Binary',
+  writable: false
+});
+
 /**
  * Updates this binary with byte_value.
  *

lib/bson/code.js

@@ -8,11 +8,15 @@
  */
 var Code = function Code(code, scope) {
   if (!(this instanceof Code)) return new Code(code, scope);
-  this._bsontype = 'Code';
   this.code = code;
   this.scope = scope;
 };
 
+Object.defineProperty(Code.prototype, '_bsontype', {
+  value: 'Code',
+  writable: false
+});
+
 /**
  * @ignore
  */

lib/bson/db_ref.js

@@ -10,12 +10,16 @@
 function DBRef(namespace, oid, db) {
   if (!(this instanceof DBRef)) return new DBRef(namespace, oid, db);
 
-  this._bsontype = 'DBRef';
   this.namespace = namespace;
   this.oid = oid;
   this.db = db;
 }
 
+Object.defineProperty(DBRef.prototype, '_bsontype', {
+  value: 'DBRef',
+  writable: false
+});
+
 /**
  * @ignore
  * @api private

lib/bson/decimal128.js

@@ -181,10 +181,14 @@ var lessThan = function(left, right) {
  * @return {Double}
  */
 var Decimal128 = function(bytes) {
-  this._bsontype = 'Decimal128';
   this.bytes = bytes;
 };
 
+Object.defineProperty(Decimal128.prototype, '_bsontype', {
+  value: 'Decimal128',
+  writable: false
+});
+
 /**
  * Create a Decimal128 instance from a string representation
  *

lib/bson/double.js

@@ -8,10 +8,14 @@
 function Double(value) {
   if (!(this instanceof Double)) return new Double(value);
 
-  this._bsontype = 'Double';
   this.value = value;
 }
 
+Object.defineProperty(Double.prototype, '_bsontype', {
+  value: 'Double',
+  writable: false
+});
+
 /**
  * Access the number value.
  *

lib/bson/int_32.js

@@ -8,10 +8,14 @@
 var Int32 = function(value) {
   if (!(this instanceof Int32)) return new Int32(value);
 
-  this._bsontype = 'Int32';
   this.value = value;
 };
 
+Object.defineProperty(Int32.prototype, '_bsontype', {
+  value: 'Int32',
+  writable: false
+});
+
 /**
  * Access the number value.
  *

lib/bson/long.js

@@ -43,7 +43,6 @@
 function Long(low, high) {
   if (!(this instanceof Long)) return new Long(low, high);
 
-  this._bsontype = 'Long';
   /**
    * @type {number}
    * @ignore
@@ -57,6 +56,11 @@ function Long(low, high) {
   this.high_ = high | 0; // force into 32 signed bits.
 }
 
+Object.defineProperty(Long.prototype, '_bsontype', {
+  value: 'Long',
+  writable: false
+});
+
 /**
  * Return the int value.
  *

lib/bson/max_key.js

@@ -6,9 +6,12 @@
  */
 function MaxKey() {
   if (!(this instanceof MaxKey)) return new MaxKey();
-
-  this._bsontype = 'MaxKey';
 }
 
+Object.defineProperty(MaxKey.prototype, '_bsontype', {
+  value: 'MaxKey',
+  writable: false
+});
+
 module.exports = MaxKey;
 module.exports.MaxKey = MaxKey;

lib/bson/min_key.js

@@ -6,9 +6,12 @@
  */
 function MinKey() {
   if (!(this instanceof MinKey)) return new MinKey();
-
-  this._bsontype = 'MinKey';
 }
 
+Object.defineProperty(MinKey.prototype, '_bsontype', {
+  value: 'MinKey',
+  writable: false
+});
+
 module.exports = MinKey;
 module.exports.MinKey = MinKey;

lib/bson/objectid.js

@@ -39,8 +39,6 @@ var ObjectID = function ObjectID(id) {
   if (id instanceof ObjectID) return id;
   if (!(this instanceof ObjectID)) return new ObjectID(id);
 
-  this._bsontype = 'ObjectID';
-
   // The most common usecase (blank id, new objectId instance)
   if (id == null || typeof id === 'number') {
     // Generate a new id
@@ -78,6 +76,11 @@ var ObjectID = function ObjectID(id) {
   if (ObjectID.cacheHexString) this.__id = this.toString('hex');
 };
 
+Object.defineProperty(ObjectID.prototype, '_bsontype', {
+  value: 'ObjectID',
+  writable: false
+});
+
 // Allow usage of ObjectId as well as ObjectID
 // var ObjectId = ObjectID;