Skip to content

Commit ad6326a

Browse files
committed
Fix regression in MongoWriteException error code
Ensure that the error code from the single WriteError is propagated to the exception error code. JAVA-4219
1 parent 1feee6c commit ad6326a

File tree

2 files changed

+40
-1
lines changed

2 files changed

+40
-1
lines changed

driver-core/src/main/com/mongodb/MongoWriteException.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public class MongoWriteException extends MongoServerException {
3333
* @param serverAddress the server address
3434
*/
3535
public MongoWriteException(final WriteError error, final ServerAddress serverAddress) {
36-
super("Write operation error on server " + serverAddress + ". Write error: " + error + ". ", serverAddress);
36+
super(error.getCode(), "Write operation error on server " + serverAddress + ". Write error: " + error + ".", serverAddress);
3737
this.error = error;
3838
}
3939

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
/*
2+
* Copyright 2008-present MongoDB, Inc.
3+
* Copyright (c) 2008-2014 Atlassian Pty Ltd
4+
*
5+
* Licensed under the Apache License, Version 2.0 (the "License");
6+
* you may not use this file except in compliance with the License.
7+
* You may obtain a copy of the License at
8+
*
9+
* http://www.apache.org/licenses/LICENSE-2.0
10+
*
11+
* Unless required by applicable law or agreed to in writing, software
12+
* distributed under the License is distributed on an "AS IS" BASIS,
13+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
* See the License for the specific language governing permissions and
15+
* limitations under the License.
16+
*/
17+
18+
package com.mongodb;
19+
20+
import org.bson.BsonDocument;
21+
import org.bson.BsonInt32;
22+
import org.junit.Test;
23+
24+
import static org.junit.jupiter.api.Assertions.assertEquals;
25+
26+
public class MongoWriteExceptionTest {
27+
28+
@Test
29+
public void testExceptionProperties() {
30+
WriteError writeError = new WriteError(11000, "Duplicate key", new BsonDocument("x", new BsonInt32(1)));
31+
MongoWriteException e = new MongoWriteException(writeError, new ServerAddress("host1"));
32+
33+
assertEquals("Write operation error on server host1:27017. Write error: WriteError{code=11000, message='Duplicate key', "
34+
+ "details={\"x\": 1}}.",
35+
e.getMessage());
36+
assertEquals(writeError.getCode(), e.getCode());
37+
assertEquals(writeError, e.getError());
38+
}
39+
}

0 commit comments

Comments
 (0)