PHPLIB-461: Fix ChangeStream tests on sharded clusters

alcaeus · alcaeus · commit 32bade4780e4 · 2019-11-15T11:39:53.000+01:00
diff --git a/tests/DocumentationExamplesTest.php b/tests/DocumentationExamplesTest.php
@@ -935,6 +935,10 @@ public function testChangeStreamExample_1_4()
     {
         $this->skipIfChangeStreamIsNotSupported();
 
+        if ($this->isShardedCluster()) {
+            $this->markTestSkipped('Test does not apply on sharded clusters: need more than a single getMore call on the change stream.');
+        }
+
         $db = new Database($this->manager, $this->getDatabaseName());
         $db->dropCollection('inventory');
         $db->createCollection('inventory');
diff --git a/tests/FunctionalTestCase.php b/tests/FunctionalTestCase.php
@@ -336,9 +336,6 @@ protected function skipIfChangeStreamIsNotSupported()
                 if (! $this->isShardedClusterUsingReplicasets()) {
                     $this->markTestSkipped('$changeStream is only supported with replicasets');
                 }
-
-                // Temporarily skip tests because of an issue with change streams in the driver
-                $this->markTestSkipped('$changeStreams currently don\'t on replica sets');
                 break;
 
             case Server::TYPE_RS_PRIMARY:
diff --git a/tests/Operation/WatchFunctionalTest.php b/tests/Operation/WatchFunctionalTest.php

Original file line number	Diff line number	Diff line change
`@@ -336,9 +336,6 @@ protected function skipIfChangeStreamIsNotSupported()`
`336`	`336`	`if (! $this->isShardedClusterUsingReplicasets()) {`
`337`	`337`	`$this->markTestSkipped('$changeStream is only supported with replicasets');`
`338`	`338`	`}`
`339`		`-`
`340`		`- // Temporarily skip tests because of an issue with change streams in the driver`
`341`		`- $this->markTestSkipped('$changeStreams currently don\'t on replica sets');`
`342`	`339`	`break;`
`343`	`340`
`344`	`341`	`case Server::TYPE_RS_PRIMARY:`