Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tokio-runtime feature flags. #970

Open
dammerung2718 opened this issue Oct 4, 2023 · 1 comment
Open

tokio-runtime feature flags. #970

dammerung2718 opened this issue Oct 4, 2023 · 1 comment
Assignees
Labels
tracked-in-jira Ticket filed in Mongo's Jira system

Comments

@dammerung2718
Copy link

To my eyes it seems having "full" features for tokio is unnecessary for the driver. Main reasons being:

  • It slows down compile times for dependent applications.
  • It slows down compile times for the driver itself.

If the crate does indeed use all the tokio features then I understand. I was willing to dwell on this journey myself but wanted to ask beforehand so as to not throw my efforts into the void.

I do not know the extent of this request. Can someone help to enlighten me?

@isabelatkinson
Copy link
Contributor

Hey @mby, off the top of my head I am not sure whether all feature flags are necessary to compile the driver. It should be fairly simple to determine this by listing them all out manually in our Cargo.toml rather than using full, deleting them one by one, and checking whether the driver will still compile with all of our own feature flags enabled. This is not a priority for the team right now, but I filed RUST-1771 for future prioritization. If you'd like to take this on feel free to make a pull request or post the result of your investigation here or on the Jira ticket!

@kevinAlbs kevinAlbs added tracked-in-jira Ticket filed in Mongo's Jira system and removed triage labels Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracked-in-jira Ticket filed in Mongo's Jira system
Projects
None yet
Development

No branches or pull requests

3 participants