feat: remove fullResponse property of commandoperationoptions

Author: baileympearson

src/collection.ts

@@ -68,12 +68,6 @@ import {
   InsertOneResult
 } from './operations/insert';
 import { IsCappedOperation } from './operations/is_capped';
-import {
-  MapFunction,
-  MapReduceOperation,
-  MapReduceOptions,
-  ReduceFunction
-} from './operations/map_reduce';
 import type { Hint, OperationOptions } from './operations/operation';
 import { OptionsOperation } from './operations/options_operation';
 import { RenameOperation, RenameOptions } from './operations/rename';
@@ -1524,79 +1518,6 @@ export class Collection<TSchema extends Document = Document> {
     return new ChangeStream<TLocal, TChange>(this, pipeline, resolveOptions(this, options));
   }
 
-  /**
-   * Run Map Reduce across a collection. Be aware that the inline option for out will return an array of results not a collection.
-   *
-   * @deprecated collection.mapReduce is deprecated. Use the aggregation pipeline instead. Visit https://docs.mongodb.com/manual/reference/map-reduce-to-aggregation-pipeline for more information on how to translate map-reduce operations to the aggregation pipeline.
-   * @param map - The mapping function.
-   * @param reduce - The reduce function.
-   * @param options - Optional settings for the command
-   * @param callback - An optional callback, a Promise will be returned if none is provided
-   */
-  mapReduce<TKey = any, TValue = any>(
-    map: string | MapFunction<TSchema>,
-    reduce: string | ReduceFunction<TKey, TValue>
-  ): Promise<Document | Document[]>;
-  mapReduce<TKey = any, TValue = any>(
-    map: string | MapFunction<TSchema>,
-    reduce: string | ReduceFunction<TKey, TValue>,
-    options: MapReduceOptions<TKey, TValue>
-  ): Promise<Document | Document[]>;
-  /** @deprecated Callbacks are deprecated and will be removed in the next major version. See [mongodb-legacy](https://github.com/mongodb-js/nodejs-mongodb-legacy) for migration assistance */
-  mapReduce<TKey = any, TValue = any>(
-    map: string | MapFunction<TSchema>,
-    reduce: string | ReduceFunction<TKey, TValue>,
-    callback: Callback<Document | Document[]>
-  ): void;
-  /** @deprecated Callbacks are deprecated and will be removed in the next major version. See [mongodb-legacy](https://github.com/mongodb-js/nodejs-mongodb-legacy) for migration assistance */
-  mapReduce<TKey = any, TValue = any>(
-    map: string | MapFunction<TSchema>,
-    reduce: string | ReduceFunction<TKey, TValue>,
-    options: MapReduceOptions<TKey, TValue>,
-    callback: Callback<Document | Document[]>
-  ): void;
-  mapReduce<TKey = any, TValue = any>(
-    map: string | MapFunction<TSchema>,
-    reduce: string | ReduceFunction<TKey, TValue>,
-    options?: MapReduceOptions<TKey, TValue> | Callback<Document | Document[]>,
-    callback?: Callback<Document | Document[]>
-  ): Promise<Document | Document[]> | void {
-    emitWarningOnce(
-      'collection.mapReduce is deprecated. Use the aggregation pipeline instead. Visit https://docs.mongodb.com/manual/reference/map-reduce-to-aggregation-pipeline for more information on how to translate map-reduce operations to the aggregation pipeline.'
-    );
-    if ('function' === typeof options) (callback = options), (options = {});
-    // Out must always be defined (make sure we don't break weirdly on pre 1.8+ servers)
-    // TODO NODE-3339: Figure out if this is still necessary given we no longer officially support pre-1.8
-    if (options?.out == null) {
-      throw new MongoInvalidArgumentError(
-        'Option "out" must be defined, see mongodb docs for possible values'
-      );
-    }
-
-    if ('function' === typeof map) {
-      map = map.toString();
-    }
-
-    if ('function' === typeof reduce) {
-      reduce = reduce.toString();
-    }
-
-    if ('function' === typeof options.finalize) {
-      options.finalize = options.finalize.toString();
-    }
-
-    return executeOperation(
-      this.s.db.s.client,
-      new MapReduceOperation(
-        this as TODO_NODE_3286,
-        map,
-        reduce,
-        resolveOptions(this, options) as TODO_NODE_3286
-      ),
-      callback
-    );
-  }
-
   /**
    * Initiate an Out of order batch write operation. All operations will be buffered into insert/update/remove commands executed out of order.
    *

src/index.ts

@@ -386,12 +386,6 @@ export type {
 export type { InsertManyResult, InsertOneOptions, InsertOneResult } from './operations/insert';
 export type { CollectionInfo, ListCollectionsOptions } from './operations/list_collections';
 export type { ListDatabasesOptions, ListDatabasesResult } from './operations/list_databases';
-export type {
-  FinalizeFunction,
-  MapFunction,
-  MapReduceOptions,
-  ReduceFunction
-} from './operations/map_reduce';
 export type { AbstractOperation, Hint, OperationOptions } from './operations/operation';
 export type { ProfilingLevelOptions } from './operations/profiling_level';
 export type { RemoveUserOptions } from './operations/remove_user';

src/operations/add_user.ts

@@ -57,7 +57,7 @@ export class AddUserOperation extends CommandOperation<Document> {
     // Error out if digestPassword set
     // v5 removed the digestPassword option from AddUserOptions but we still want to throw
     // an error when digestPassword is provided.
-    if ('digestPassword' in options && options.digestPassword != null) {
+    if ((options as any).digestPassword != null) {
       return callback(
         new MongoInvalidArgumentError(
           'Option "digestPassword" not supported via addUser, use db.command(...) instead'

src/operations/map_reduce.ts

@@ -1007,7 +1007,7 @@ export function applySession(
     if (
       session.supports.causalConsistency &&
       session.operationTime &&
-      commandSupportsReadConcern(command, options)
+      commandSupportsReadConcern(command)
     ) {
       command.readConcern = command.readConcern || {};
       Object.assign(command.readConcern, { afterClusterTime: session.operationTime });

src/sessions.ts

@@ -1328,21 +1328,8 @@ export function shuffle<T>(sequence: Iterable<T>, limit = 0): Array<T> {
 
 // TODO: this should be codified in command construction
 // @see https://github.com/mongodb/specifications/blob/master/source/read-write-concern/read-write-concern.rst#read-concern
-export function commandSupportsReadConcern(command: Document, options?: Document): boolean {
-  if (command.aggregate || command.count || command.distinct || command.find || command.geoNear) {
-    return true;
-  }
-
-  if (
-    command.mapReduce &&
-    options &&
-    options.out &&
-    (options.out.inline === 1 || options.out === 'inline')
-  ) {
-    return true;
-  }
-
-  return false;
+export function commandSupportsReadConcern(command: Document): boolean {
+  return command.aggregate || command.count || command.distinct || command.find || command.geoNear;
 }
 
 /** A utility function to get the instance of mongodb-client-encryption, if it exists. */