Skip to content

Commit 39c7699

Browse files
authored
test(NODE-6807): move benchmark tags into correct place (#4452)
1 parent 8b34213 commit 39c7699

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

test/benchmarks/driver_bench/src/driver.mts

+7-4
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ export type Metric = {
135135
name: 'megabytes_per_second' | 'normalized_throughput';
136136
value: number;
137137
metadata: {
138+
tags?: string[];
138139
improvement_direction: 'up' | 'down';
139140
};
140141
};
@@ -143,7 +144,6 @@ export type MetricInfo = {
143144
info: {
144145
test_name: string;
145146
args: Record<string, number>;
146-
tags?: string[];
147147
};
148148
metrics: Metric[];
149149
};
@@ -159,12 +159,15 @@ export function metrics(test_name: string, result: number, tags?: string[]): Met
159159
key,
160160
typeof value === 'number' ? value : value ? 1 : 0
161161
])
162-
),
163-
tags
162+
)
164163
},
165164
// FIXME(NODE-6781): For now all of our metrics are of throughput so their improvement_direction is up,
166165
metrics: [
167-
{ name: 'megabytes_per_second', value: result, metadata: { improvement_direction: 'up' } }
166+
{
167+
name: 'megabytes_per_second',
168+
value: result,
169+
metadata: { tags, improvement_direction: 'up' }
170+
}
168171
]
169172
} as const;
170173
}

0 commit comments

Comments
 (0)