removed unnecesary helper funcs

Author: aditi-khare-mongoDB

src/cmap/handshake/client_metadata.ts

@@ -93,16 +93,7 @@ type MakeClientMetadataOptions = Pick<MongoOptions, 'appName' | 'driverInfo'>;
  */
 export function makeClientMetadata(options: MakeClientMetadataOptions): ClientMetadata {
   let metadataDocument = new LimitedSizeDocument(512);
-  metadataDocument = addNonEnvClientMetadata(options, metadataDocument);
-  metadataDocument = addFAASOnlyEnvClientMetadata(metadataDocument);
-  return metadataDocument.toObject() as ClientMetadata;
-}
 
-/** @internal */
-export function addNonEnvClientMetadata(
-  options: MakeClientMetadataOptions,
-  metadataDocument: LimitedSizeDocument
-): LimitedSizeDocument {
   const { appName = '' } = options;
   // Add app name first, it must be sent
   if (appName.length > 0) {
@@ -152,11 +143,6 @@ export function addNonEnvClientMetadata(
     }
   }
 
-  return metadataDocument;
-}
-
-/** @internal */
-function addFAASOnlyEnvClientMetadata(metadataDocument: LimitedSizeDocument): LimitedSizeDocument {
   const faasEnv = getFAASEnv();
   if (faasEnv != null) {
     if (!metadataDocument.ifItFitsItSits('env', faasEnv)) {
@@ -167,7 +153,7 @@ function addFAASOnlyEnvClientMetadata(metadataDocument: LimitedSizeDocument): Li
       }
     }
   }
-  return metadataDocument;
+  return metadataDocument.toObject() as ClientMetadata;
 }
 
 let isDocker: boolean;