fix(NODE-3343): allow overriding result document after projection applied #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Jun 23, 2021
dariakp
added
the
Primary Review
dariakp
requested changes
Jun 24, 2021
|
|
||
| // $ExpectType Cursor<{ name: string; }> | ||
| typedCollection.find().project<{ name: string }>({ name: 1 }); | ||
| expectType<FindCursor<{ name: string }>>(typedCollection.find().project({ name: 1 })); |
There was a problem hiding this comment.
is there a way to add at least one expectNotType test here?
There was a problem hiding this comment.
Also it looks like a number of assertions are failing in the pipeline
There was a problem hiding this comment.
Added two! pipeline should be clear, of course clarity is key so let me know if there's more I can add to cover more use cases.
dariakp
added
Team Review
emadum
approved these changes
Jun 24, 2021
durran
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for users to override the resulting documents after a projection is applied.
A furhter improvement could be to use the projection to filter the keys out of the schema but that requires the projection to be a const type. I leave that up to a future feature request.