-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-3793): Remove offensive language from code and tests #3082
Conversation
General question: Are these changes covered by tests? I tried changing the return value of slaveOk() in db.ts to both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just capturing this particular thought for now, not a full review
Going to add a few more tests. Will comment here when I'm done |
I've finished adding tests. This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
Description
NODE-3793
What is changing?
Remove and deprecate (when removal is not possible) all references to "slaveOk" in the source code and tests. Note that spec test updates are being tracked in NODE-3791
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Following the guidance documented in tools.ietf.org/id/draft-knodel-terminology-00.html, we will remove all oppressive and unnecessarily gendered language in driver documentation, code, tests, specs, and spec tests.
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>