Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-4156): remove comment from commands pre-4.4 #3195

Merged
merged 3 commits into from
Apr 13, 2022
Merged

fix(NODE-4156): remove comment from commands pre-4.4 #3195

merged 3 commits into from
Apr 13, 2022

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Apr 7, 2022 •
edited
Loading

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review April 8, 2022 14:40
@baileympearson baileympearson changed the title remove comment from commands pre-4.4 fix(NODE-4156): remove comment from commands pre-4.4 Apr 11, 2022
@nbbeeken nbbeeken self-requested a review April 11, 2022 18:18
nbbeeken
nbbeeken requested changes Apr 11, 2022
View reviewed changes
test/tools/unified-spec-runner/match.ts Outdated Show resolved Hide resolved
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 11, 2022
nbbeeken
nbbeeken previously approved these changes Apr 12, 2022
View reviewed changes
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Apr 12, 2022
@nbbeeken nbbeeken requested a review from durran April 12, 2022 15:59
nbbeeken
nbbeeken requested changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this with all the CI clean up we've done recently we should be able to get a green run

@baileympearson baileympearson force-pushed the NODE-4156-fix-comment-applied-to-operations branch from 68dea9c to 525c946 Compare April 13, 2022 15:27
@nbbeeken nbbeeken merged commit 4e6dccd into main Apr 13, 2022
@nbbeeken nbbeeken deleted the NODE-4156-fix-comment-applied-to-operations branch April 13, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@durran durran Awaiting requested review from durran

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baileympearson @nbbeeken