Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-4519): deprecate promiseLibrary and PromiseProvider #3403

Merged
merged 5 commits into from
Sep 12, 2022
Merged

feat(NODE-4519): deprecate promiseLibrary and PromiseProvider #3403

merged 5 commits into from
Sep 12, 2022

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Sep 9, 2022

Description

What is changing?

Added the deprecation tag to the API docs for promiseLibrary

What is the motivation for this change?

async/await in the future

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review September 9, 2022 15:00
baileympearson
baileympearson requested changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to deprecate the PromiseProvider class because it's exported, right?

@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 12, 2022
baileympearson
baileympearson requested changes Sep 12, 2022
View reviewed changes
test/types/mongodb.test-d.ts Outdated Show resolved Hide resolved
@baileympearson baileympearson added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Sep 12, 2022
@baileympearson baileympearson merged commit 5c322b6 into main Sep 12, 2022
@baileympearson baileympearson deleted the NODE-4519/deprecatePromiseLib branch September 12, 2022 16:57
@baileympearson baileympearson changed the title feat(NODE-4519): deprecate promiseLibrary and check for emitted warning feat(NODE-4519): deprecate promiseLibrary and PromiseProvider Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

@baileympearson baileympearson baileympearson approved these changes

@durran durran durran approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nbbeeken @durran @baileympearson @dariakp