Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-5272): do not create or drop ecc collections #3678

Merged
merged 1 commit into from
May 24, 2023
Merged

feat(NODE-5272): do not create or drop ecc collections #3678

merged 1 commit into from
May 24, 2023

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented May 19, 2023 •
edited by nbbeeken
Loading

Description

What is changing?

The driver no longer creates an ecc collection when creating an encrypted collection.

Additionally, the QE v2 protocol requires 7.0+ servers. This means that driver 4.x would be incompatible with QE unless we bump the max wire version for 4.x to 21.

Backport of #3660

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the base branch from main to 4.x May 19, 2023 20:37
@baileympearson baileympearson marked this pull request as ready for review May 22, 2023 16:10
@nbbeeken nbbeeken self-requested a review May 23, 2023 14:20
@nbbeeken nbbeeken self-assigned this May 23, 2023
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 23, 2023
@baileympearson baileympearson force-pushed the NODE-5272-backport-ecc-collection-fix branch from a13a103 to 2c719b1 Compare May 24, 2023 18:02
@baileympearson baileympearson requested a review from nbbeeken May 24, 2023 18:02
@nbbeeken nbbeeken changed the title fix(Node-5272): backport ecc collection fix fix(NODE-5272): backport ecc collection fix May 24, 2023
@nbbeeken nbbeeken mentioned this pull request May 24, 2023
Merged
5 tasks
@nbbeeken
Copy link
Contributor

@baileympearson Is "fix" correct here? asking because the original PR was a feat

@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels May 24, 2023
@baileympearson
Copy link
Contributor Author

baileympearson commented May 24, 2023 •
edited
Loading

I think so - why was the original PR a feat? @nbbeeken

  • QE is experimental, so the breakage is okay
  • this fixes a bug with QE and 7.0 servers, where we'd create extra unnecessary collections

@baileympearson baileympearson changed the title fix(NODE-5272): backport ecc collection fix feat(NODE-5272): backport ecc collection fix May 24, 2023
@nbbeeken nbbeeken changed the title feat(NODE-5272): backport ecc collection fix feat(NODE-5272): do not create or drop ecc collections May 24, 2023
@nbbeeken nbbeeken merged commit d26ad61 into 4.x May 24, 2023
@nbbeeken nbbeeken deleted the NODE-5272-backport-ecc-collection-fix branch May 24, 2023 20:41
@github-actions github-actions bot mentioned this pull request Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baileympearson @nbbeeken