Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-5355): prevent error when saslprep is not a function #3733

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jun 16, 2023

Description

What is changing?

Prevents an error when saslprep is not a function.

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review June 20, 2023 16:58
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting on confirmation of a manual test, changes LGTM

@baileympearson baileympearson changed the title prevent error when saslprep is not a function fix(NODE-5355): prevent error when saslprep is not a function Jun 20, 2023
@nbbeeken nbbeeken merged commit 152425a into 3.7 Jun 20, 2023
@nbbeeken nbbeeken deleted the NODE-5355 branch June 20, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants