Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-5190)!: remove deprecated keep alive options #3771

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Conversation

durran
Copy link
Member

@durran durran commented Jul 12, 2023

Description

Remove the deprecated keep alive options.

What is changing?

  • Removes the keepAlive and keepAliveInitialDelay options.
  • Sets TCP keep alive to 30000 on the socket.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5190

Release Highlight

The deprecated keepAlive and keepAliveInitialDelay options have been removed.

TCP keep alive will always be on and now set to a value of 30000ms.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 12, 2023
@W-A-James W-A-James added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jul 12, 2023
src/cmap/connect.ts Show resolved Hide resolved
@W-A-James W-A-James self-assigned this Jul 13, 2023
@W-A-James W-A-James merged commit 7ade907 into main Jul 13, 2023
@W-A-James W-A-James deleted the NODE-5190 branch July 13, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants