-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-3689): require hello command for connection handshake to use OP_MSG disallowing OP_QUERY #3938
Conversation
…e OP_MSG disallowing OP_QUERY
… to not set a serverApi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alenakhineika looks like we've got a consistent test failure: https://parsley.mongodb.com/test/mongo_node_driver_next_rhel8_new_connection_tests_test_5.0_server_patch_ad2d15c4f612463fbc591a1463fe81551c8cdac3_656f31c657e85af49b8fb05a_23_12_05_14_20_56/0/ab7f52f017caee84d74f0eba0699342f?bookmarks=0,7&shareLine=1
Description
Always perform the initial handshake as hello + OP_MSG in the load-balanced mode or when serverApi is specified.
What is changing?
Is there new documentation needed for these changes?
No
What is the motivation for this change?
NODE-3689
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript