Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-5717): make ExceededTimeLimit retryable reads error #3947

Merged
merged 2 commits into from
Dec 11, 2023
Merged

feat(NODE-5717): make ExceededTimeLimit retryable reads error #3947

merged 2 commits into from
Dec 11, 2023

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Dec 11, 2023 •
edited
Loading

Description

What is changing?

Previously ExceededTimeLimit related only to retryable writes errors. Now it belongs both to RETRYABLE_WRITE_ERROR_CODES and RETRYABLE_READ_ERROR_CODES arrays.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5717

Release Highlight

ExceededTimeLimit was made a retryable reads error

The reading operations will be resumed after receiving the ExceededTimeLimit error.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@alenakhineika alenakhineika marked this pull request as ready for review December 11, 2023 15:11
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Dec 11, 2023
W-A-James
W-A-James previously approved these changes Dec 11, 2023
View reviewed changes
@W-A-James W-A-James added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Dec 11, 2023
aditi-khare-mongoDB
aditi-khare-mongoDB previously approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

baileympearson
baileympearson reviewed Dec 11, 2023
View reviewed changes
src/error.ts Outdated Show resolved Hide resolved
@W-A-James W-A-James merged commit 106ab09 into main Dec 11, 2023
26 checks passed
@W-A-James W-A-James deleted the NODE-5717-make-exceeded-time-limit-retryable-reads-error branch December 11, 2023 21:02
@github-actions github-actions bot mentioned this pull request Dec 11, 2023
Merged
@alenakhineika alenakhineika changed the title feat(NODE-5717): make ExceededTimeLimit retryable reads error feat(NODE-5791): make ExceededTimeLimit retryable reads error Dec 20, 2023
@alenakhineika alenakhineika changed the title feat(NODE-5791): make ExceededTimeLimit retryable reads error feat(NODE-5717): make ExceededTimeLimit retryable reads error Dec 20, 2023
aditi-khare-mongoDB pushed a commit that referenced this pull request Dec 21, 2023
@alenakhineika @aditi-khare-mongoDB
feat(NODE-5717): make ExceededTimeLimit retryable reads error (#3947)
dbd221a
@akanchhaS akanchhaS mentioned this pull request May 18, 2024
Open
@lydmoon lydmoon mentioned this pull request May 19, 2024
Open
@lryanle lryanle mentioned this pull request May 21, 2024
Open
@baby636 baby636 mentioned this pull request May 21, 2024
Open
@IdrizMirena IdrizMirena mentioned this pull request May 22, 2024
Open
@mkusztal mkusztal mentioned this pull request May 24, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request May 24, 2024
Open
@arenault-pass arenault-pass mentioned this pull request May 24, 2024
Closed
@lryanle lryanle mentioned this pull request May 24, 2024
Open
@akanchhaS akanchhaS mentioned this pull request May 25, 2024
Open
@boytur boytur mentioned this pull request May 25, 2024
Closed
@lydmoon lydmoon mentioned this pull request May 25, 2024
Open
@boytur boytur mentioned this pull request May 26, 2024
Open
@mkusztal mkusztal mentioned this pull request May 27, 2024
Open
@lydmoon lydmoon mentioned this pull request May 27, 2024
Open
@akanchhaS akanchhaS mentioned this pull request May 27, 2024
Open
@mkusztal mkusztal mentioned this pull request May 28, 2024
Open
@lryanle lryanle mentioned this pull request May 28, 2024
Open
@boytur boytur mentioned this pull request May 28, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request May 28, 2024
Open
This was referenced Jun 2, 2024
Open
Merged
@lydmoon lydmoon mentioned this pull request Jun 6, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Jun 6, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Jun 6, 2024
Open
@lryanle lryanle mentioned this pull request Jun 6, 2024
Open
@mkusztal mkusztal mentioned this pull request Jun 7, 2024
Open
@astitva3110 astitva3110 mentioned this pull request Jun 8, 2024
Open
@gardnern gardnern mentioned this pull request Jun 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson left review comments

@aditi-khare-mongoDB aditi-khare-mongoDB aditi-khare-mongoDB approved these changes

@W-A-James W-A-James W-A-James approved these changes

Assignees

@W-A-James W-A-James

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alenakhineika @baileympearson @W-A-James @aditi-khare-mongoDB @nbbeeken