Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-5609): node driver omits base64 padding in sasl-continue command #3975

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Jan 24, 2024

Description

Ensure that we don't strip padded "=" from saslStart responses that are passed to saslContinue.

What is changing?

We replace the existing parsing using split that kills trailing “=”s with regex parsing that preserves trailing “=”s.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5609

Release Highlight

The base64 padding is now preserved in the saslContinue command

The authentication was rejected by the saslContinue command from mongosh due to missing "=" padding from the client. We fixed the way we parse payload to preserve trailing "="s.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@alenakhineika alenakhineika marked this pull request as ready for review January 25, 2024 14:51
@durran durran self-assigned this Jan 26, 2024
@durran durran added Primary Review In Review with primary reviewer, not yet ready for team's eyes and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jan 26, 2024
@durran durran removed their assignment Jan 26, 2024
@nbbeeken nbbeeken self-assigned this Jan 26, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 26, 2024
@nbbeeken nbbeeken assigned W-A-James and unassigned nbbeeken Jan 26, 2024
@W-A-James
Copy link
Contributor

Failing tests are either known flaky or unrelated

@W-A-James W-A-James merged commit b7d28d3 into main Jan 26, 2024
17 of 27 checks passed
@W-A-James W-A-James deleted the NODE-5609-preserve-padding-in-sasl-continue branch January 26, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants