-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-5968): Container and Kubernetes Awareness #4005
Merged
nbbeeken
merged 16 commits into
main
from
NODE-5968/6.x-container-and-kubernetes-awareness
Mar 6, 2024
Merged
feat(NODE-5968): Container and Kubernetes Awareness #4005
nbbeeken
merged 16 commits into
main
from
NODE-5968/6.x-container-and-kubernetes-awareness
Mar 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditi-khare-mongoDB
changed the title
EOD commit
feat(NODE-5968): Container and Kubernetes Awareness
Feb 27, 2024
nbbeeken
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Feb 29, 2024
aditi-khare-mongoDB
force-pushed
the
NODE-5968/6.x-container-and-kubernetes-awareness
branch
from
February 29, 2024 19:42
6da9072
to
7140454
Compare
added tests - no docker tests removed extraneous export and newline removed extraneous export and newline removed unnecesary helper funcs removed unnecesary let, changed to const added more tests to comply w kickoff - no docker tests still cleared up logic
aditi-khare-mongoDB
force-pushed
the
NODE-5968/6.x-container-and-kubernetes-awareness
branch
from
February 29, 2024 19:44
7140454
to
03e5e13
Compare
nbbeeken
requested changes
Feb 29, 2024
nbbeeken
requested changes
Mar 1, 2024
nbbeeken
requested changes
Mar 4, 2024
nbbeeken
added
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
Mar 4, 2024
nbbeeken
requested changes
Mar 4, 2024
aditi-khare-mongoDB
force-pushed
the
NODE-5968/6.x-container-and-kubernetes-awareness
branch
from
March 4, 2024 19:48
6355e4e
to
25d1b44
Compare
This was referenced Jun 29, 2024
This was referenced Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Track user usage of containers.
What is changing?
When kubernetes is in
process.env
, we add a{orchestrator: 'kubernetes'}
field to theclient.env
field of the handshake document (if this does not make the document exceed 512 bytes).When '/.dockerenv' exists, we add a
{runtime: 'docker'}
field to theclient.env
field of the handshake document (if this does not make the document exceed 512 bytes).Note: We do not unit test docker, but I tested our logic for detecting docker on an EVG Host, ran Docker and detection succeeds for both root and non-root user cases.
Is there new documentation needed for these changes?
No, non-user facing change.
What is the motivation for this change?
Product wants to track user usage of docker and kubernetes.
Release Highlight
Container and Kubernetes Awareness
The Node.js driver now keeps track of container metadata in the
client.env.container
field of the handshake document.If space allows, the following metadata will be included in
client.env.container
:Note: If neither Kubernetes nor Docker is present,
client.env
will not have thecontainer
property.Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript