-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-5971): attach v
to createIndexes command when version
is specified
#4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
NODE-5971-index-v-option
branch
from
March 19, 2024 14:11
10b0a19
to
79084c8
Compare
baileympearson
changed the title
misc test fixes
fix(NODE-5971): attach Mar 19, 2024
v
to createIndexes command when version
is specified
W-A-James
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Mar 19, 2024
W-A-James
reviewed
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one optional change
W-A-James
previously approved these changes
Mar 20, 2024
W-A-James
added
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
Mar 20, 2024
nbbeeken
reviewed
Mar 20, 2024
W-A-James
approved these changes
Mar 20, 2024
nbbeeken
approved these changes
Mar 20, 2024
This was referenced Sep 6, 2024
This was referenced Sep 7, 2024
This was referenced Sep 24, 2024
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
createIndex
andcreateIndexes
now support specifying an index version with theversion
option.One note is that
createIndexes()
requires that users specify theversion
as a part of their index specification - aversion
provided as a part of the options is ignored. This behavior is consistent with other index options provided tocreateIndexes
.Is there new documentation needed for these changes?
What is the motivation for this change?
(release highlight left empty since
v
is an undocumented feature, no need for it to appear in our release notes)Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript