Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-5971): attach v to createIndexes command when version is specified #4043

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Mar 18, 2024

Description

What is changing?

createIndex and createIndexes now support specifying an index version with the version option.

One note is that createIndexes() requires that users specify the version as a part of their index specification - a version provided as a part of the options is ignored. This behavior is consistent with other index options provided to createIndexes.

Is there new documentation needed for these changes?

What is the motivation for this change?

(release highlight left empty since v is an undocumented feature, no need for it to appear in our release notes)

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title misc test fixes fix(NODE-5971): attach v to createIndexes command when version is specified Mar 19, 2024
@baileympearson baileympearson marked this pull request as ready for review March 19, 2024 14:34
@W-A-James W-A-James self-requested a review March 19, 2024 20:07
@W-A-James W-A-James self-assigned this Mar 19, 2024
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 19, 2024
Copy link
Contributor

@W-A-James W-A-James left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one optional change

src/operations/indexes.ts Outdated Show resolved Hide resolved
W-A-James
W-A-James previously approved these changes Mar 20, 2024
@W-A-James W-A-James added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Mar 20, 2024
src/operations/indexes.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants