-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-5678): add options parsing support for timeoutMS and defaultTimeoutMS #4068
Merged
durran
merged 27 commits into
main
from
NODE-5678/add-options-parsing-support-for-timeoutMS-and-defaultTimeoutMS
Apr 10, 2024
Merged
feat(NODE-5678): add options parsing support for timeoutMS and defaultTimeoutMS #4068
durran
merged 27 commits into
main
from
NODE-5678/add-options-parsing-support-for-timeoutMS-and-defaultTimeoutMS
Apr 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W-A-James
changed the title
convert to typescript
feat(NODE-5678): add options parsing support for timeoutMS and defaultTimeoutMS
Apr 3, 2024
W-A-James
commented
Apr 5, 2024
src/operations/operation.ts
Outdated
Comment on lines
37
to
39
|
||
/** @internal */ | ||
timeoutMS?: number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applies to all operations, including cursor operations
NOTE: leaving release highlight blank for this PR as we are not making any of these changes public until CSOT release |
…meoutMS-and-defaultTimeoutMS
durran
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Apr 8, 2024
This was referenced Sep 6, 2024
This was referenced Sep 7, 2024
This was referenced Sep 24, 2024
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
timeoutMS
option changestimeoutMS
field to the following option InterfacesCollectionOptions
AbstractCursorOptions
DbOptions
GridFSBucketReadStreamOptions
GridFSBucketOptions
GridFSBucketWriteStreamOptions
MongoClientOptions
MongoOptions
OperationOptions
timeoutMS
field toClientSession
timeoutMS
defaultTimeoutMS
option changesdefaultTimeoutMS
field toClientSessionOptions
Test changes
timeoutMS
option support to uri spec runnertimeoutMS
client option teststimeoutMS
option inheritancemisc improvements
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript