Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(NODE-6127): move error construction into setTimeout callback #4094

Merged
merged 2 commits into from
Apr 23, 2024
Merged

perf(NODE-6127): move error construction into setTimeout callback #4094

merged 2 commits into from
Apr 23, 2024

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Apr 23, 2024 •
edited
Loading

Description

What is changing?

  • Make TimeoutError construction lazy
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James changed the title move error construction out of Timeout constructor fix(NODE-5825): move error construction out of Timeout constructor Apr 23, 2024
@W-A-James W-A-James changed the title fix(NODE-5825): move error construction out of Timeout constructor perf(NODE-5825): move error construction out of Timeout constructor Apr 23, 2024
@W-A-James W-A-James changed the title perf(NODE-5825): move error construction out of Timeout constructor perf(NODE-6127): move error construction out of Timeout constructor Apr 23, 2024
@W-A-James W-A-James marked this pull request as ready for review April 23, 2024 20:09
@nbbeeken nbbeeken self-assigned this Apr 23, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 23, 2024
@nbbeeken nbbeeken changed the title perf(NODE-6127): move error construction out of Timeout constructor perf(NODE-6127): move error construction into setTimeout callback Apr 23, 2024
@nbbeeken nbbeeken merged commit 6abc074 into main Apr 23, 2024
19 of 26 checks passed
@nbbeeken nbbeeken deleted the fixTimeoutRegression branch April 23, 2024 22:00
@github-actions github-actions bot mentioned this pull request Apr 23, 2024
Merged
@NotZarifGithub NotZarifGithub mentioned this pull request May 24, 2024
Open
@kazimanzurrashid kazimanzurrashid mentioned this pull request May 24, 2024
Merged
@tdbaine tdbaine mentioned this pull request May 24, 2024
Open
@arenault-pass arenault-pass mentioned this pull request May 24, 2024
Closed
@lryanle lryanle mentioned this pull request May 24, 2024
Open
@calvin-kimani calvin-kimani mentioned this pull request May 24, 2024
Open
@akanchhaS akanchhaS mentioned this pull request May 25, 2024
Open
@DenoneroDev DenoneroDev mentioned this pull request May 25, 2024
Open
@boytur boytur mentioned this pull request May 25, 2024
Closed
@prernaadev01 prernaadev01 mentioned this pull request May 25, 2024
Closed
@James220903 James220903 mentioned this pull request May 25, 2024
Open
@lydmoon lydmoon mentioned this pull request May 25, 2024
Open
@boytur boytur mentioned this pull request May 26, 2024
Open
@mkusztal mkusztal mentioned this pull request May 27, 2024
Open
@lydmoon lydmoon mentioned this pull request May 27, 2024
Open
@akanchhaS akanchhaS mentioned this pull request May 27, 2024
Open
@mkusztal mkusztal mentioned this pull request May 28, 2024
Open
@ijunxyz123 ijunxyz123 mentioned this pull request Aug 25, 2024
Open
@aretexit aretexit mentioned this pull request Aug 28, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Aug 28, 2024
Closed
@jaspreetd jaspreetd mentioned this pull request Sep 2, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Sep 3, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Sep 3, 2024
Open
@lryanle lryanle mentioned this pull request Sep 3, 2024
Open
@lydmoon lydmoon mentioned this pull request Sep 3, 2024
Open
@mkusztal mkusztal mentioned this pull request Sep 3, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Sep 4, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 6, 2024
Closed
This was referenced Sep 6, 2024
Merged
Merged
This was referenced Sep 7, 2024
Closed
Closed
@snyk-io snyk-io bot mentioned this pull request Sep 16, 2024
Open
@sunil-lakshman sunil-lakshman mentioned this pull request Sep 18, 2024
Closed
This was referenced Sep 24, 2024
Closed
Closed
Closed
Closed
@MohammadGhajari MohammadGhajari mentioned this pull request Sep 27, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Sep 28, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Sep 28, 2024
Open
@lydmoon lydmoon mentioned this pull request Sep 28, 2024
Open
@lryanle lryanle mentioned this pull request Sep 28, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Sep 28, 2024
Open
@aretexit aretexit mentioned this pull request Sep 28, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 29, 2024
Open
@mkusztal mkusztal mentioned this pull request Sep 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@W-A-James @nbbeeken