Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-6244): Bump max supported wire version and server version #4163

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Jun 27, 2024

Description

What is changing?

Bump MAX_SUPPORTED_WIRE_VERSION and MAX_SUPPORTED_SERVER_VERSION to support upcoming release of MongoDB 8.0.

Is there new documentation needed for these changes?

No

What is the motivation for this change?

Release Highlight

Driver supports Wire Protocol of upcoming server release

Increased the driver's max supported Wire Protocol version and Server version in preparation for the upcoming release of MongoDB 8.0.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James marked this pull request as ready for review June 27, 2024 20:09
@durran durran self-assigned this Jun 27, 2024
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 27, 2024
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably import MAX_SUPPORTED_WIRE_VERSION into the failing wire_version.test.js for the message so we don't miss that each time we update it.

@W-A-James W-A-James requested a review from durran June 27, 2024 20:59
@durran durran merged commit 45bc098 into main Jun 27, 2024
29 checks passed
@durran durran deleted the NODE-6244 branch June 27, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants