feat(NODE-5459): add durations to connection pool events #4166
+101
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
added
the
Primary Review
baileympearson
requested changes
Jul 3, 2024
baileympearson
requested changes
Jul 8, 2024
nbbeeken
reviewed
Jul 9, 2024
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
baileympearson
approved these changes
Jul 11, 2024
nbbeeken
approved these changes
Jul 11, 2024
baileympearson
deleted the
NODE-5459/add-durations-to-connection-pool-events
branch
This was referenced Oct 5, 2024
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add durations to ConnectionReadyEvent, ConnectionCheckedOutEvent, ConnectionCheckOutFailedEvent.
Sync Spec Tests.
What is changing?
See release highlights.
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
Spec compliance.
Release Highlight
Add duration indicating time elapsed between connection creation and when the connection is ready
ConnectionReadyEventnow has adurationMSproperty that represents the time between the connection creation event and when the connection ready event is fired.Add duration indicating time elapsed between the beginning and end of a connection checkout operation
ConnectionCheckedOutEvent/ConnectionCheckFailedEventnow have adurationMSproperty that represents the time between checkout start and success/failure.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript