Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-6362): cache cursor deserialization options across deserialize calls #4221

Merged
merged 3 commits into from
Sep 9, 2024
Merged

fix(NODE-6362): cache cursor deserialization options across deserialize calls #4221

merged 3 commits into from
Sep 9, 2024

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Sep 4, 2024 •
edited
Loading

Description

What is changing?

Forward-port of #4220.

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fixed enableUtf8Validation option

Starting in v6.8.0 we inadvertently removed the ability to disable UTF-8 validation when deserializing BSON. Validation is normally a good thing, but it was always meant to be configurable and the recent Node.js runtime issues (v22.7.0) make this option indispensable for avoiding errors from mistakenly generated invalid UTF-8 bytes.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title feat(NODE-6309): Mark range API as stable (#4190) fix(todo-xxxxx): cache cursor deserialization options across deserialize calls (#4190) Sep 5, 2024
@baileympearson baileympearson force-pushed the fix-regress branch 3 times, most recently from a598416 to 5e9bbc2 Compare September 6, 2024 16:32
@baileympearson baileympearson changed the title fix(todo-xxxxx): cache cursor deserialization options across deserialize calls (#4190) fix(NODE-6362): cache cursor deserialization options across deserialize calls (#4190) Sep 6, 2024
@baileympearson baileympearson marked this pull request as ready for review September 9, 2024 15:41
@nbbeeken nbbeeken self-assigned this Sep 9, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 9, 2024
nbbeeken
nbbeeken requested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick fixes

test/integration/node-specific/bson-options/utf8_validation.test.ts Outdated Show resolved Hide resolved
test/integration/node-specific/bson-options/utf8_validation.test.ts Show resolved Hide resolved
@nbbeeken nbbeeken changed the title fix(NODE-6362): cache cursor deserialization options across deserialize calls (#4190) fix(NODE-6362): cache cursor deserialization options across deserialize calls Sep 9, 2024
@nbbeeken nbbeeken merged commit 833eaa4 into main Sep 9, 2024
26 of 30 checks passed
@nbbeeken nbbeeken deleted the fix-regress branch September 9, 2024 18:48
@nbbeeken nbbeeken mentioned this pull request Sep 9, 2024
Merged
This was referenced Oct 3, 2024
Merged
Merged
Merged
Merged
Closed
@skanda890 skanda890 mentioned this pull request Oct 4, 2024
Merged
@aravindbuilt aravindbuilt mentioned this pull request Oct 4, 2024
Closed
@akanchhaS akanchhaS mentioned this pull request Oct 4, 2024
Open
@zntb zntb mentioned this pull request Oct 4, 2024
Closed
@MohammadGhajari MohammadGhajari mentioned this pull request Oct 4, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Oct 4, 2024
Open
@lryanle lryanle mentioned this pull request Oct 4, 2024
Open
@lydmoon lydmoon mentioned this pull request Oct 4, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Oct 4, 2024
Closed
@issam-seghir issam-seghir mentioned this pull request Oct 4, 2024
Open
@TartejBrothers TartejBrothers mentioned this pull request Oct 4, 2024
Merged
@visrut-at-incubyte visrut-at-incubyte mentioned this pull request Oct 4, 2024
Open
@IzzyDotExe IzzyDotExe mentioned this pull request Oct 4, 2024
Merged
This was referenced Oct 5, 2024
Merged
Merged
Merged
@arenault-pass arenault-pass mentioned this pull request Oct 5, 2024
Closed
@MoaidHashem3 MoaidHashem3 mentioned this pull request Oct 5, 2024
Open
@mkusztal mkusztal mentioned this pull request Oct 5, 2024
Open
@WontonSam WontonSam mentioned this pull request Oct 5, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Oct 6, 2024
Closed
@Abhishekh669 Abhishekh669 mentioned this pull request Oct 25, 2024
Open
@aliakseikrauchanka aliakseikrauchanka mentioned this pull request Oct 25, 2024
Open
@parseplatformorg parseplatformorg mentioned this pull request Oct 26, 2024
Closed
@Xcaciv Xcaciv mentioned this pull request Oct 26, 2024
Open
@MohammadGhajari MohammadGhajari mentioned this pull request Oct 28, 2024
Open
@lydmoon lydmoon mentioned this pull request Oct 28, 2024
Open
@xeni09 xeni09 mentioned this pull request Oct 28, 2024
Merged
@abaum65 abaum65 mentioned this pull request Oct 29, 2024
Open
@mentorscx mentorscx mentioned this pull request Nov 7, 2024
Open
@prosenjit07 prosenjit07 mentioned this pull request Nov 8, 2024
Open
@parseplatformorg parseplatformorg mentioned this pull request Nov 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baileympearson @nbbeeken