Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-6365): pass through allowPartialTrustChain TLS flag #4228

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

addaleax
Copy link
Contributor

@addaleax addaleax commented Sep 9, 2024

Will leave this in draft until the upstream Node.js PR is merged.

Refs: nodejs/node#54790

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Allow passing through allowPartialTrustChain Node.js TLS option

This option is now exposed through the MongoClient constructor's options parameter and controls the X509_V_FLAG_PARTIAL_CHAIN OpenSSL flag.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@addaleax addaleax marked this pull request as ready for review September 9, 2024 15:25
@nbbeeken nbbeeken self-assigned this Sep 9, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 9, 2024
@nbbeeken nbbeeken self-requested a review September 9, 2024 15:28
src/connection_string.ts Show resolved Hide resolved
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an option we need to propagate everywhere for FLE? If so, we need to also adapt state_machine.ts. We have TS types there, as well as special logic to only propagate a handful of TLS options to KMS requests. @nbbeeken

@addaleax
Copy link
Contributor Author

addaleax commented Sep 9, 2024

@baileympearson Replied on Slack as well, but I think this falls under a broader "users should be able to specify Node.js TLS options for FLE" umbrella, right now it's already only a fairly limited subset of options that's supported there

@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Sep 9, 2024
@nbbeeken nbbeeken merged commit d6c147d into mongodb:main Sep 9, 2024
27 of 30 checks passed
@addaleax addaleax deleted the 6365-dev branch September 9, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants