-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-6365): pass through allowPartialTrustChain
TLS flag
#4228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an option we need to propagate everywhere for FLE? If so, we need to also adapt state_machine.ts. We have TS types there, as well as special logic to only propagate a handful of TLS options to KMS requests. @nbbeeken
@baileympearson Replied on Slack as well, but I think this falls under a broader "users should be able to specify Node.js TLS options for FLE" umbrella, right now it's already only a fairly limited subset of options that's supported there |
Will leave this in draft until the upstream Node.js PR is merged.Refs: nodejs/node#54790
Description
What is changing?
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Allow passing through
allowPartialTrustChain
Node.js TLS optionThis option is now exposed through the MongoClient constructor's options parameter and controls the
X509_V_FLAG_PARTIAL_CHAIN
OpenSSL flag.Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript